Skip to content

GH-50824: [R] Fix shellcheck errors in the r/tools/download_dependencies_R.sh - #50825

Merged
kou merged 1 commit into
apache:mainfrom
hiroyuki-sato:topic/download_dependencies_R
Aug 12, 2026
Merged

GH-50824: [R] Fix shellcheck errors in the r/tools/download_dependencies_R.sh#50825
kou merged 1 commit into
apache:mainfrom
hiroyuki-sato:topic/download_dependencies_R

Conversation

@hiroyuki-sato

@hiroyuki-sato hiroyuki-sato commented Aug 6, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Collaborator

Rationale for this change

This is the sub issue #44748.

  • SC2086: Double quote to prevent globbing and word splitting.
shellcheck r/tools/download_dependencies_R.sh

In r/tools/download_dependencies_R.sh line 48:
  echo 'download.file("'${url}'", "'${out}'", quiet = TRUE)'
                        ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                    ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  echo 'download.file("'"${url}"'", "'"${out}"'", quiet = TRUE)'


In r/tools/download_dependencies_R.sh line 59:
  source ${SOURCE_DIR}/cpp/thirdparty/versions.txt
         ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  source "${SOURCE_DIR}"/cpp/thirdparty/versions.txt

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

What changes are included in this PR?

  • SC2086: Quote variable

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

⚠️ GitHub issue #50824 has been automatically assigned in GitHub to PR creator.

@hiroyuki-sato

hiroyuki-sato commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

@github-actions crossbow submit test-r-offline-maximal

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Revision: a58b6c2

Submitted crossbow builds: ursacomputing/crossbow @ actions-62f8e0cdba

Task Status
test-r-offline-maximal GitHub Actions

@uros-b

uros-b commented Aug 10, 2026

Copy link
Copy Markdown
Member

LGTM, thank you @hiroyuki-sato!

@github-actions github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Aug 10, 2026
@hiroyuki-sato

hiroyuki-sato commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator Author

@kou Could you take a look at this PR？
Do we need more reviewer？

kou
kou approved these changes Aug 12, 2026
View reviewed changes

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 485499f into apache:main Aug 12, 2026
35 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Aug 12, 2026
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Aug 12, 2026
@kou kou mentioned this pull request Aug 12, 2026
Closed
@kou

kou commented Aug 12, 2026

Copy link
Copy Markdown
Member

In general, more reviewers are better for stronger/healthy community. :-)

@conbench-apache-arrow

conbench-apache-arrow Bot commented Aug 12, 2026

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 485499f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.

@conbench-apache-arrow

conbench-apache-arrow Bot commented Aug 12, 2026

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 485499f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.

@hiroyuki-sato
hiroyuki-sato deleted the topic/download_dependencies_R branch August 13, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes
@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner
@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner
+1 more reviewer
@uros-b uros-b uros-b approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting merge Awaiting merge Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hiroyuki-sato @uros-b @kou